Conversation
Member
ymtszw
commented
Jan 30, 2025
ymtszw
commented
- test: guard in assert_match/2
- chore: use mise and direnv for development
- chore: Elixir 1.18 drops ~R//
- ci: drop Erlang 23, support 27
KyosukeUryu
reviewed
Jan 31, 2025
| test "should work with guards" do | ||
| assert_match(%{key: 1}, map when is_map_key(map, :key)) | ||
|
|
||
| # guard works with assert_match/2 but has limitation: bindings inside patterns cannot be used from outside |
Contributor
There was a problem hiding this comment.
= match演算子ではassertionと同時に束縛できたがmatch?/2を利用するmatchだと束縛はできないのは確かに制限事項となりますね 📝
Member
Author
|
Mergeしてtag打ちます |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.